Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar sync for a SSO #49

Merged
merged 1 commit into from May 24, 2018
Merged

Fix avatar sync for a SSO #49

merged 1 commit into from May 24, 2018

Conversation

@klaufel
Copy link
Contributor

klaufel commented May 15, 2018

Working on the web "http://nintenderos.com" we were having an avatars synchronization problem. Reading the official documentation of Disqus I observed that the value of the parameter that is required in the configuration "avatar" is a url and the function that currently exists get_avatar() returns <img src="..."> when it should return a string with a url.

Image with Disqus documentation:
image

I have modified the function by get_avatar_url() so that it always returns the url of the avatar, so when the avatar value is updated it will show the new avatar.

@webrender

This comment has been minimized.

Copy link
Contributor

webrender commented May 24, 2018

Thanks for this PR! We're going to run some tests against it and hopefully release an update which includes it tomorrow.

@webrender webrender merged commit d2926d5 into disqus:master May 24, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dmatt

This comment has been minimized.

Copy link
Collaborator

dmatt commented May 25, 2018

@klaufel We finished testing and your PR made it into the recent 3.0.16 release, https://wordpress.org/plugins/disqus-comment-system/#developers. Thank you!

@psbaj

This comment has been minimized.

Copy link

psbaj commented May 28, 2018

Thank you so much for this fix! I contacted disqus support last year about this issue and they told me that the problem was my server ¬¬ well, not a problem anymore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.