Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Disable comments when comment status is closed for the post #1

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

infynyxx commented Mar 4, 2011

Currently, Disqus plugin doesn't work when setting for auto-disable comments after given days is enabled

screencap

@ghost

ghost commented Mar 10, 2011

Hi,

Can you send our support your debug information found under advanced options? help@disqus.com

Thanks,

Giannii

Contributor

thetylerhayes commented Apr 17, 2012

The proposed change would simply prevent Disqus from rendering if comments are closed in WordPress itself. Ideal expected functionality would be that Disqus is still rendered and that the comment thread is closed similarly in Disqus (probably via an API endpoint) when the close action is fired in WordPress. I'll look into determining the feasibility of this API integration and, if feasible, making this a more native functionality UX-wise.

Contributor

archon810 commented Apr 17, 2012

Tyler, what you're saying is better, but if the close action is fired from Wordpress upon closing comments, that means existing closed comments wouldn't be supported by this if you've migrated to Disqus after having an established comment base.

Disqus should perhaps try to detect whether a given post has comments closed in WP but not in Disqus, and if they're not closed on the remote side, issue a close action. Not sure what the best way is, but simply setting a flag that gets passed to the JS form would be a good start. The problem is, spammers can figure this out and unset the flag, unless you have a security mechanism in place that uses hashed API secret/key to pass parameters to the form.

Contributor

thetylerhayes commented Apr 17, 2012

Those are two different features. One is a manual action that fires whenever you actively change a status in WP itself. The second is a syncing action which should be performed during the import process (if it isn't already) to make sure threads in Disqus reflect the same status as in WordPress. I'll do some import testing to see if this is already the case.

Contributor

archon810 commented Apr 17, 2012

OK, fair enough, that would work too if both are in place.

ryanvalentin pushed a commit that referenced this pull request Jul 21, 2016

Merge pull request #1 from archon810/archon810-patch-dsq_sync_forum
check if dsq_sync_forum is already scheduled before scheduling it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment