Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depositing fails when disallowing third-party javascript #454

Closed
a3nm opened this issue Sep 24, 2017 · 4 comments

Comments

@a3nm
Copy link
Member

commented Sep 24, 2017

When using uMatrix to block third-party javascript, depositing silently fails (the "processing" animation stays indefinitely), because of a dependency on cdnjs.cloudflare.com. Ideally, we could remove this dependency, or at least detect when third-party JS is blocked and display an explicit error.

(Edit: not sure whether this really prevented the deposit for completing; it's very slow, so maybe I wasn't patient enough. Anyway, it would still be good to remove this dependency if appropriate.)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@a3nm a3nm added the enhancement label Sep 24, 2017

@wetneb

This comment has been minimized.

Copy link
Member

commented Sep 24, 2017

We have the following scripts:

I had looked into self-hosting mathjax but I think it was quite complicated - @a3nm I think you have some experience in that? The others should be easier to migrate - they are probably just included by third-party django libraries.

@Phyks

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

fetch and d3 could be easily self-hosted, I'll look into making a PR for this.

I'll have a look at MathJax.

EDIT: Self-hosting MathJax seems feasible https://docs.mathjax.org/en/latest/start.html#downloading-and-installing-mathjax.

@Phyks Phyks self-assigned this Jan 25, 2019

Phyks added a commit to Phyks/dissemin that referenced this issue Jan 25, 2019

@Phyks Phyks added the front end label Jan 25, 2019

Phyks added a commit to Phyks/dissemin that referenced this issue Feb 18, 2019

Phyks added a commit to Phyks/dissemin that referenced this issue Feb 18, 2019

@Phyks

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

I added some doc in #598 about self-hosting MathJax. Once this is merged, we can apply it to dissem.in. :)

@wetneb

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

Deployed in dissem.in.

@wetneb wetneb closed this Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.