Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No log when -fplugin or -spec parameters are used #343

Closed
DirtYiCE opened this issue Jun 1, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@DirtYiCE
Copy link

commented Jun 1, 2019

It took me a while to figure out why doesn't my kernel compilation works through distcc. Logs looks like something like this:

distccd[24617] (dcc_check_compiler_masq) /usr/bin/armv7a-unknown-linux-gnueabihf-gcc is a safe symlink to /usr/x86_64-pc-linux-gnu/armv7a-unknown-linux-gnueabihf/gcc-bin/8.3.0/armv7a-unknown-linux-gnueabihf-gcc
distccd[24617] (dcc_check_compiler_whitelist) armv7a-unknown-linux-gnueabihf-gcc in/usr/lib/distcc whitelist
distccd[24617] (dcc_cleanup_tempfiles_inner) deleted 5 temporary files
distccd[24617] (dcc_job_summary) client: 10.248.117.169:59478 OTHER exit:0 sig:0 core:0 ret:0 time:1592ms

It just mentions that the compiler is in the whitelist, then the next thing logged is deleting temporary files. Looking at the code we can see it's just a single goto to a common error handling part:

for (i = 0; (a = argv[i]); i++)

@shawnl

This comment has been minimized.

Copy link
Collaborator

commented Jun 1, 2019

Ahh yes, I guess these should be allowed when --enable-tcp-insecure is passed.

@DirtYiCE

This comment has been minimized.

Copy link
Author

commented Jun 1, 2019

But wouldn't that require extra logic though? You need to copy the plugin file too and it obviously won't work if the server and the client is running on a different architecture.
I'd be happy with a single log that states you can't distcc this file because it uses -fplugin instead of silently failing.

@shawnl

This comment has been minimized.

Copy link
Collaborator

commented Jun 1, 2019

yeah it would try to use a file on the other side that wouldn't be there. (which is what it did before I added that logic).

shawnl added a commit to shawnl/distcc that referenced this issue Jun 1, 2019

@shawnl shawnl closed this in 34d864e Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.