Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling mistakes. #286

Merged
merged 1 commit into from Sep 25, 2018
Merged

Correct spelling mistakes. #286

merged 1 commit into from Sep 25, 2018

Conversation

@EdwardBetts
Copy link
Contributor

@EdwardBetts EdwardBetts commented Jun 8, 2018

No description provided.

@@ -118,7 +118,7 @@ int dcc_compress_file_lzo1x(int in_fd,
/**
* Send LZO-compressed bulk data.
*
* The most straighforward method for miniLZO is to just send everything in
* The most straightforward method for miniLZO is to just send everything in
* one big chunk. So we just read the whole input into a buffer, build the
* output in a buffer, and send it once its complete.

This comment has been minimized.

@pepsiman

pepsiman Jun 8, 2018

"it's"

This comment has been minimized.

@TafThorne

TafThorne Jun 20, 2018
Collaborator

Or as we could be formal and unambiguous "it is"

DCC_COMPRESS_NONE = 69,
DCC_COMPRESS_LZO1X
};

enum dcc_cpp_where {
/* wierd values to catch errors */
/* weird values to catch errors */

This comment has been minimized.

@TafThorne

TafThorne Jun 20, 2018
Collaborator

I wonder if this was meant to say "wired values" as in "hard wired values to catch errors". Weird does not make that much sense to me.

Copy link
Collaborator

@TafThorne TafThorne left a comment

Overall the changes look good to me. There is one question on whether a word should be "weird" or "wired". If I knew the answer I would pick Approve or Request but as I am uncertain I can only comment for now.

@afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Jun 20, 2018

@TafThorne: it is "weird", as in 42 and 69 versus say 0 and 1

enum dcc_compress {
    /* weird values to catch errors */
    DCC_COMPRESS_NONE     = 69,
    DCC_COMPRESS_LZO1X
};

enum dcc_cpp_where {
    /* weird values to catch errors */
    DCC_CPP_ON_CLIENT     = 42,
    DCC_CPP_ON_SERVER
};

Unless soldering, things are hardcoded rather than hardwired ?

@TafThorne
Copy link
Collaborator

@TafThorne TafThorne commented Jun 22, 2018

Unless soldering, things are hardcoded rather than hardwired ?

I do firmware meaning not FPGAs but embedded software meaning not FPGAs but C and C++ code on microprocessors meaning not Intel x86 but actually small micros, no not the ARM things in Pi's, actually small ones. It all gets rather wire like and words have lots of meanings at the same times.

If poeople agree weird is the way to go that sounds good to me.

@thedrow thedrow merged commit c77c626 into distcc:master Sep 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.