daemon: --allow-private fixes #451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to run a distccd server with --allow-private would fail with the following error in the native parsing path: distccd[1] (dcc_parse_mask) ERROR: can't parse internet address "fe80::"
There is a big warning that --allow-private is used if no --allow block is specified, but it is not actually enforced: the check on opt_allow_private happens directly in parsing before it is set. It just leaves opt_allowed set to NULL, which allows all inbound connections and is not what the warning claims
not having rfc2553 makes ipv6 not working, and there is little reason one would not want to use getaddrinfo etc functions nowadays (tested to build on linux and freebsd)
vt-alt
pushed a commit
to altlinux/specs
that referenced
this pull request
Sep 15, 2022
- Repaired IP based access control (Closes: #42251) - Added systemd unit file (Closes: #40669) - Improved --allow-private, see distcc/distcc#451 - Removed clients.allow, commands.allow.sh: these have never ever worked - Avoid infinite loop when DISTCC_BACKOFF is disabled, see distcc/distcc#434 - Refuse to distribute files with the `.incbin` assembler directive, see distcc/distcc#461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three commits are widely independent, if you don't agree with any of them I'd suggest just dropping the dubious patches, merge what we can, and continue with the other(s) more leisurely.
--allow-privatewould fail on alpine, because rfc2553 is not explicitly enabled and the code chokes on ipv6 address parsing.--allowoption would print a big warning that--allow-privateis assumed instead, but not actually do anything with itThanks!