Fix tests in pump mode #460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make check` is also running tests for the pump mode (`pump-maintainer-check` target) but they were all falling back to the usual preprocessor mode as the include server was not started. This is solved by prepending `pump` to the distcc invocations and also some trivially failing tests are fixed or disabled when they make no sense in pump mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkis also running tests for the pump mode(
pump-maintainer-checktarget) but they were all falling back tothe usual preprocessor mode as the include server was not started.
This is solved by prepending
pumpto the distcc invocations andalso some trivially failing tests are fixed or disabled when they
make no sense in pump mode.