New user metadata namespace for Overview page #2826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
added
Server
Code Infrastructure
Dashboard
portante
previously approved these changes
May 6, 2022
portante
previously approved these changes
May 9, 2022
webbnh
requested changes
May 9, 2022
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
I feel like this is a considerable departure from the previous vision of how the metadata namespaces would be used. The old model seemed pretty solid and comprehensive...whereas this seems like the new keys don't fit well and the change seems to remove support for third-party clients...am I misunderstanding this change?
dbutenhof
commented
May 9, 2022
Member
Author
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
Apparently I need to do some more noodling here. (Sigh.)
portante
previously approved these changes
May 12, 2022
dbutenhof
added a commit
to dbutenhof/pbench
that referenced
this pull request
May 13, 2022
PBENCH-445 I've been talking about this a long time; after pushing PR distributed-system-analysis#2826 which will require rebuilding the DB, I figured I might as well try to take this additional step at the same time. There are a lot of changed files; most of the changes (including the legacy test gold files) are small and straightforward.
webbnh
previously approved these changes
May 13, 2022
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
My brain is filling up, so I'm going to go ahead and post this now.
If I hit any issues with the tests, I'll post a follow-up.
webbnh
reviewed
May 13, 2022
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
I found a few more things that you might want to consider (but, I also may have cast my net too wide...).
portante
previously approved these changes
May 14, 2022
riya-17
previously approved these changes
May 16, 2022
PBENCH-645 This change repurposes the "user.*" Dataset Metadata namespace as a per-user key space, where each authenticated client with READ access to a given dataset will be able to write independent metadata attached to that dataset. (Only the owner has UPDATE access to change the "global" metadata keys in the "dashboard.*" namespace.) At the Metadata internal class level, methods now allow specifying a User to associate each item of metadata. At the API level, the user is always the authenticated user (or None for only global metadata). (An unauthenticated client can ask for `user.*` keys, but the value will always be None as authenticated clients will never create global values for the `user.*` namespace and unauthenticated clients can't ever set metadata values.
portante
approved these changes
May 16, 2022
dbutenhof
added a commit
to dbutenhof/pbench
that referenced
this pull request
May 16, 2022
PBENCH-445 I've been talking about this a long time; after pushing PR distributed-system-analysis#2826 which will require rebuilding the DB, I figured I might as well try to take this additional step at the same time. There are a lot of changed files; most of the changes (including the legacy test gold files) are small and straightforward.
dbutenhof
added a commit
to dbutenhof/pbench
that referenced
this pull request
May 17, 2022
PBENCH-445 I've been talking about this a long time; after pushing PR distributed-system-analysis#2826 which will require rebuilding the DB, I figured I might as well try to take this additional step at the same time. There are a lot of changed files; most of the changes (including the legacy test gold files) are small and straightforward.
dbutenhof
added a commit
that referenced
this pull request
May 18, 2022
PBENCH-445 I've been talking about this a long time; after pushing PR #2826 which will require rebuilding the DB, I figured I might as well try to take this additional step at the same time. There are a lot of changed files; most of the changes (including the legacy test gold files) are small and straightforward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-645
This change re-purposes the
user.*Dataset Metadata namespace as a per-user key space, where each authenticated client with READ access to a given dataset will be able to write independent metadata attached to that dataset. (Only the owner has UPDATE access to change the "global" metadata keys in the "dashboard.*" namespace.)At the Metadata internal class level, methods now allow specifying a
Userto associate each item of metadata. At the API level, the user is always the authenticated user (or None for only global metadata).An unauthenticated client can ask for
user.*keys, but the value will always be None as authenticated clients will never create global values for theuser.*namespace and unauthenticated clients can't ever set metadata values.