Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.7] Fix vndr and check #3001

Merged
merged 1 commit into from Dec 17, 2019

Conversation

dmcgowan
Copy link
Collaborator

@dmcgowan dmcgowan commented Sep 3, 2019

Signed-off-by: Derek McGowan derek@mcgstyle.net

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #3001 into release/2.7 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/2.7    #3001   +/-   ##
============================================
  Coverage        60.25%   60.25%           
============================================
  Files              103      103           
  Lines             8024     8024           
============================================
  Hits              4835     4835           
  Misses            2546     2546           
  Partials           643      643
Flag Coverage Δ
#linux 60.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269d18d...5883e2d. Read the comment docs.

@@ -5,7 +5,6 @@
"EnableGC": true,
"Enable": [
"structcheck",
"staticcheck",
Copy link
Contributor

@caervs caervs Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmcgowan why the removal of static check?

Copy link
Collaborator Author

@dmcgowan dmcgowan Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static check is failing on this branch and it is not requirement. It will remain on the master branch. The number of fixes related to static check is too large to backport imo.

@thaJeztah
Copy link
Member

thaJeztah commented Sep 5, 2019

Looks like this was because a different versions of vndr was used before; should we pin vndr to a fixed version?

@dmcgowan
Copy link
Collaborator Author

dmcgowan commented Dec 13, 2019

@thaJeztah vndr changes can be annoying, but it doesn't happen very often and is usually a sensible change anyway. Better to just update the code than pin vndr I think.

As for staticcheck, I just don't think it is worth figuring all that out on the 2.7 code base, we can in master.

Copy link
Member

@thaJeztah thaJeztah left a comment

LGTM

@dmcgowan dmcgowan merged commit a85caea into distribution:release/2.7 Dec 17, 2019
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants