Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.7]fix go check issues #3531

Merged
merged 1 commit into from Nov 17, 2021

Conversation

wy65701436
Copy link
Collaborator

@wy65701436 wy65701436 commented Nov 16, 2021

G404: Replace math rand with crypto rand

Signed-off-by: Wang Yan wangyan@vmware.com

G404: Replace math rand with crypto rand

Signed-off-by: Wang Yan <wangyan@vmware.com>
@wy65701436 wy65701436 changed the title fix go check issues [release/2.7]fix go check issues Nov 16, 2021
@thaJeztah
Copy link
Member

thaJeztah commented Nov 16, 2021

should we enable gosec in the golangci-lint config? https://github.com/distribution/distribution/blob/main/.golangci.yml#L2

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #3531 (9a3ff11) into release/2.7 (691e62e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/2.7    #3531      +/-   ##
===============================================
- Coverage        58.77%   58.74%   -0.03%     
===============================================
  Files              102      102              
  Lines             7085     7088       +3     
===============================================
  Hits              4164     4164              
- Misses            2280     2282       +2     
- Partials           641      642       +1     
Impacted Files Coverage Δ
...b.com/docker/distribution/registry/handlers/app.go 45.99% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691e62e...9a3ff11. Read the comment docs.

@milosgajdos
Copy link
Member

milosgajdos commented Nov 16, 2021

should we enable gosec in the golangci-lint config? https://github.com/distribution/distribution/blob/main/.golangci.yml#L2

I think that's a good idea, but hmm, I wonder what can of worms will that open 😅

@milosgajdos
Copy link
Member

milosgajdos commented Nov 17, 2021

As a follow up to this, it seems to be be more of a recommendation, but having checked some perf benchmarks comparisons between the two methods, I think we should merge this in without much worry.

Copy link
Member

@thaJeztah thaJeztah left a comment

LGTM

@milosgajdos milosgajdos merged commit 4313c14 into distribution:release/2.7 Nov 17, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants