Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] Release workflow #3565

Merged
merged 1 commit into from Jan 13, 2022
Merged

Conversation

crazy-max
Copy link
Contributor

@crazy-max crazy-max commented Jan 12, 2022

follow-up #3552

degraded backport of #3315 to be able to trigger a release on release/2.8 branch without artifacts releasing.

cc @milosgajdos @thaJeztah

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max

This comment has been minimized.

@crazy-max crazy-max marked this pull request as draft Jan 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #3565 (65ca39e) into release/2.8 (3b7b534) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/2.8    #3565   +/-   ##
============================================
  Coverage        58.72%   58.72%           
============================================
  Files              102      102           
  Lines             7104     7104           
============================================
  Hits              4172     4172           
  Misses            2286     2286           
  Partials           646      646           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b7b534...65ca39e. Read the comment docs.

@crazy-max crazy-max marked this pull request as ready for review Jan 12, 2022
@milosgajdos milosgajdos requested a review from thaJeztah Jan 12, 2022
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
flavor: |
latest=false
labels: |
org.opencontainers.image.title=Distribution
Copy link
Member

@milosgajdos milosgajdos Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be lowercase?

Copy link
Contributor Author

@crazy-max crazy-max Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it from README: https://github.com/distribution/distribution#distribution
Other references also have capitalization: ...goals of the Distribution project?

Copy link
Member

@milosgajdos milosgajdos Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no strong opinions -- just wondering out loud. PR looks great! I think it's fine to leave it like this

Copy link
Member

@thaJeztah thaJeztah Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions either; Is this label actively used anywhere that we know of?

Copy link
Member

@milosgajdos milosgajdos Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont believe it is -- I think it's just @crazy-max adding it from the goodness of his heart for the people who might be interested in using it

Copy link
Contributor Author

@crazy-max crazy-max Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe yes that can be useful to have this kind of info ^^
Here is a sample output:

image

Copy link
Contributor Author

@crazy-max crazy-max Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the license, revision, etc... as labels when the image is being built.

Copy link
Contributor Author

@crazy-max crazy-max Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also by default org.opencontainers.image.title and org.opencontainers.image.description will use the one from the GitHub API if we remove these override. In our case would result with:

  • org.opencontainers.image.title: "distribution" (repo name)
  • org.opencontainers.image.description: "The toolkit to pack, ship, store, and deliver container content" (repo description)

So we can remove them in the workflow if the default ones suit to you

Copy link
Member

@milosgajdos milosgajdos Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kewl. There is no harm keeping them in. Thanks @crazy-max

Copy link
Member

@thaJeztah thaJeztah left a comment

SGTM

@milosgajdos milosgajdos merged commit 1840415 into distribution:release/2.8 Jan 13, 2022
3 checks passed
@crazy-max crazy-max deleted the 2.8-gha branch Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants