Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] Release artifacts #3568

Merged
merged 1 commit into from Jan 21, 2022

Conversation

crazy-max
Copy link
Contributor

@crazy-max crazy-max commented Jan 18, 2022

follow-up #3565

As discussed with @milosgajdos, we might need to also publish artifacts to GitHub Release like it's already done on the main branch. Will look like this:

image

image

# create the artifact matching your current platform in ./bin
docker buildx bake artifact

# create artifacts for many platforms in ./bin
docker buildx bake artifact-all

Waiting for inputs from maintainers so keeping in draft for now.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #3568 (d31d67c) into release/2.8 (1840415) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/2.8    #3568   +/-   ##
============================================
  Coverage        58.72%   58.72%           
============================================
  Files              102      102           
  Lines             7104     7104           
============================================
  Hits              4172     4172           
  Misses            2286     2286           
  Partials           646      646           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1840415...d31d67c. Read the comment docs.

@crazy-max crazy-max marked this pull request as ready for review Jan 19, 2022
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
FROM scratch AS artifacts
COPY --from=build /out/*.tar.gz /
COPY --from=build /out/*.zip /
COPY --from=build /out/*.sha256 /
Copy link
Contributor Author

@crazy-max crazy-max Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also publish checksums (cc @milosgajdos @thaJeztah)

Copy link
Member

@thaJeztah thaJeztah left a comment

SGTM

@milosgajdos milosgajdos merged commit 359b97a into distribution:release/2.8 Jan 21, 2022
3 checks passed
@crazy-max crazy-max deleted the 2.8-artifacts branch Jan 21, 2022
@crazy-max crazy-max mentioned this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants