New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized divergences -- Renyi, Tsallis, Hellinger, and alpha, with many tests #87

Merged
merged 3 commits into from Jun 4, 2015

Conversation

Projects
None yet
4 participants
@marcharper
Copy link
Contributor

marcharper commented Jun 4, 2015

Hi all, I added some popular generalized divergences to dit. Take a look and if you like what you see, please merge it in!

@landscape-bot

This comment has been minimized.

Copy link

landscape-bot commented Jun 4, 2015

Code Health
Repository health increased by 0.07% when pulling 6c01a7f on marcharper:generalized_divergences into 1385ddf on dit:master.

@landscape-bot

This comment has been minimized.

Copy link

landscape-bot commented Jun 4, 2015

Code Health
Repository health increased by 0.07% when pulling ac39d9e on marcharper:generalized_divergences into 1385ddf on dit:master.

@chebee7i

This comment has been minimized.

Copy link
Member

chebee7i commented Jun 4, 2015

Looks great! Thanks @marcharper. Will merge tomorrow if no one else does before then.

@chebee7i

This comment has been minimized.

Copy link
Member

chebee7i commented Jun 4, 2015

The test failures can be ignored...I just pushed a fix for that.

@Autoplectic

This comment has been minimized.

Copy link
Member

Autoplectic commented Jun 4, 2015

Nice! Looks good to me too, but I'd like to see it rebased on master just so we can have a clean travis check before merging.

@chebee7i

This comment has been minimized.

Copy link
Member

chebee7i commented Jun 4, 2015

Sure. @marcharper, something like the following should do it:

git remote add upstream https://github.com/dit/dit.git
git fetch upstream

git rebase upstream/master
git push -f

@marcharper marcharper force-pushed the marcharper:generalized_divergences branch from ac39d9e to b20f835 Jun 4, 2015

@landscape-bot

This comment has been minimized.

Copy link

landscape-bot commented Jun 4, 2015

Code Health
Repository health increased by 0.07% when pulling b20f835 on marcharper:generalized_divergences into 6fedaac on dit:master.

@landscape-bot

This comment has been minimized.

Copy link

landscape-bot commented Jun 4, 2015

Code Health
Repository health increased by 0.09% when pulling de4b5d5 on marcharper:generalized_divergences into 6fedaac on dit:master.

@marcharper

This comment has been minimized.

Copy link
Contributor Author

marcharper commented Jun 4, 2015

I added some more tests (for divergence positivity), looks like it all clears just fine.

@Autoplectic

This comment has been minimized.

Copy link
Member

Autoplectic commented Jun 4, 2015

Very nice, thank you Marc! I don't see any reason not to merge now.

chebee7i added a commit that referenced this pull request Jun 4, 2015

Merge pull request #87 from marcharper/generalized_divergences
Generalized divergences -- Renyi, Tsallis, Hellinger, and alpha, with many tests

@chebee7i chebee7i merged commit 9d2d0dc into dit:master Jun 4, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.16%) to 74.72%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment