diff --git a/src/main/java/org/dita/dost/reader/SubjectSchemeReader.java b/src/main/java/org/dita/dost/reader/SubjectSchemeReader.java index 9fe6717465..b2f41b79a1 100644 --- a/src/main/java/org/dita/dost/reader/SubjectSchemeReader.java +++ b/src/main/java/org/dita/dost/reader/SubjectSchemeReader.java @@ -200,10 +200,7 @@ public void processEnumerationDef(final Element schemeRoot, final Element enumer // Put default values. final String keyValue = child.getAttribute(ATTRIBUTE_NAME_KEYREF); if (keyValue != null) { - Map S = defaultValueMap.get(attributeName); - if (S == null) { - S = new HashMap<>(); - } + final Map S = defaultValueMap.getOrDefault(attributeName, new HashMap<>()); S.put(elementName, keyValue); defaultValueMap.put(attributeName, S); } @@ -215,14 +212,8 @@ public void processEnumerationDef(final Element schemeRoot, final Element enumer } final Element subTree = searchForKey(schemeRoot, keyValue); if (subTree != null) { - Map> S = bindingMap.get(attributeName); - if (S == null) { - S = new HashMap<>(); - } - Set A = S.get(elementName); - if (A == null) { - A = new HashSet<>(); - } + final Map> S = bindingMap.getOrDefault(attributeName, new HashMap<>()); + final Set A = S.getOrDefault(elementName, new HashSet<>()); if (!A.contains(subTree)) { // Add sub-tree to valid values map putValuePairsIntoMap(subTree, elementName, attributeName, keyValue); @@ -283,15 +274,8 @@ private void putValuePairsIntoMap( return; } - Map> valueMap = validValuesMap.get(attName); - if (valueMap == null) { - valueMap = new HashMap<>(); - } - - Set valueSet = valueMap.get(elementName); - if (valueSet == null) { - valueSet = new HashSet<>(); - } + final Map> valueMap = validValuesMap.getOrDefault(attName, new HashMap<>()); + final Set valueSet = valueMap.getOrDefault(elementName, new HashSet<>()); final LinkedList queue = new LinkedList<>(); queue.offer(subtree); @@ -303,7 +287,7 @@ private void putValuePairsIntoMap( } if (SUBJECTSCHEME_SUBJECTDEF.matches(node)) { final String key = node.getAttribute(ATTRIBUTE_NAME_KEYS); - if (!(key == null || key.trim().isEmpty() || key.equals(category))) { + if (!(key.trim().isEmpty() || key.equals(category))) { valueSet.add(key); } }