New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keydef containing uplevels #2667

Closed
fviolette opened this Issue Apr 21, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@fviolette

fviolette commented Apr 21, 2017

In my DITA Map I define a key to an image:
<keydef keys="arch_diagram" href="../../introduction/images/arch_diagram.png" format="png"/>

With the keyref:
<image keyref="arch_diagram"/>

It's not expanded in 2.3.3 or 2.4.6 but is in 1.8.
Other keyrefs to keys without uplevels and all other images are impacted.

Also, I have the same issue as #2420, except the conref has also uplevels.

@jelovirt jelovirt added this to the 2.5 milestone Apr 23, 2017

jelovirt added a commit that referenced this issue Apr 23, 2017

Fix resolving image keys #2667
Image keys were resolved against temporary directory when they should be
resolved against declaring map URI.

@jelovirt jelovirt closed this Apr 23, 2017

@mironovalexey

This comment has been minimized.

Show comment
Hide comment
@mironovalexey

mironovalexey Apr 24, 2017

Contributor

Jarno, I'm sorry. Non-image and non-dita links should be resolved here against the keyDef.source as well.

Then #2581 could be closed too.

Contributor

mironovalexey commented Apr 24, 2017

Jarno, I'm sorry. Non-image and non-dita links should be resolved here against the keyDef.source as well.

Then #2581 could be closed too.

@jelovirt

This comment has been minimized.

Show comment
Hide comment
@jelovirt

jelovirt Apr 24, 2017

Member

@mironovalexey Moved the non-image and non-DITA fix discussion to #2581 (comment)

Member

jelovirt commented Apr 24, 2017

@mironovalexey Moved the non-image and non-DITA fix discussion to #2581 (comment)

@fviolette

This comment has been minimized.

Show comment
Hide comment
@fviolette

fviolette Apr 30, 2017

Only testing now - thanks a lot! 👍

fviolette commented Apr 30, 2017

Only testing now - thanks a lot! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment