New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect DITAArchVersion in Topic RNG modules #2705

Closed
raducoravu opened this Issue May 25, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@raducoravu
Member

raducoravu commented May 25, 2017

In the RNG file "plugins\org.oasis-open.dita.v1_3\rng\base\rng\topicMod.rng" search for:

     <attribute name="dita:DITAArchVersion" a:defaultValue="1.2"/>

The default version value should be 1.3. In our case this leads to Oxygen interpreting opened RNG-based topics as being DITA 1.2 compliant and not enabling various DITA 1.3 editing features in them.

@jelovirt

This comment has been minimized.

Show comment
Hide comment
@jelovirt

jelovirt May 25, 2017

Member

Has this been reported to DITA TC? I would prefer TC to fix this and we just use the latest versions of the schemas. It's slower, though.

Member

jelovirt commented May 25, 2017

Has this been reported to DITA TC? I would prefer TC to fix this and we just use the latest versions of the schemas. It's slower, though.

@drmacro

This comment has been minimized.

Show comment
Hide comment
@drmacro

drmacro May 25, 2017

Member

I just checked my local version of the RNG source and the 1.2 value is present there as well, so I guess we need to add that as an errata.

I did a search and couldn't find a:defaultValue="1.2" anywhere else.

It is correctly set to 1.3 in mapMod.rng

Looks like those are the only two places where dita: DITAArchVersion is set in the RNG

Member

drmacro commented May 25, 2017

I just checked my local version of the RNG source and the 1.2 value is present there as well, so I guess we need to add that as an errata.

I did a search and couldn't find a:defaultValue="1.2" anywhere else.

It is correctly set to 1.3 in mapMod.rng

Looks like those are the only two places where dita: DITAArchVersion is set in the RNG

@robander

This comment has been minimized.

Show comment
Hide comment
@robander

robander May 26, 2017

Member

I sent email to the TC to make sure it gets tracked and goes into the next errata.

It's such a trivial item -- and will definitely be part of the next errata -- that I'd be fine shipping the fix already. (More like the early days when DITA didn't ship official errrata, just posted updated zips.)

https://lists.oasis-open.org/archives/dita/201705/msg00080.html

Member

robander commented May 26, 2017

I sent email to the TC to make sure it gets tracked and goes into the next errata.

It's such a trivial item -- and will definitely be part of the next errata -- that I'd be fine shipping the fix already. (More like the early days when DITA didn't ship official errrata, just posted updated zips.)

https://lists.oasis-open.org/archives/dita/201705/msg00080.html

@robander

This comment has been minimized.

Show comment
Hide comment
@robander

robander May 31, 2017

Member

I've now checked this fix into the OASIS source code repository, so it will ship with the second errata, whenever that is available. I'd consider it safe to fix in (presumably) the first patch to 2.5.

Member

robander commented May 31, 2017

I've now checked this fix into the OASIS source code repository, so it will ship with the second errata, whenever that is available. I'd consider it safe to fix in (presumably) the first patch to 2.5.

@jelovirt

This comment has been minimized.

Show comment
Hide comment
@jelovirt

jelovirt May 31, 2017

Member

This should be shipped in 2.5.1.

Member

jelovirt commented May 31, 2017

This should be shipped in 2.5.1.

@jelovirt jelovirt added the bug label May 31, 2017

@jelovirt jelovirt added this to the 2.5.1 milestone May 31, 2017

@robander

This comment has been minimized.

Show comment
Hide comment
@robander

robander May 31, 2017

Member

Fixed with b2d8e95

Member

robander commented May 31, 2017

Fixed with b2d8e95

@robander robander closed this May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment