Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for revprop on <tm> element in PDF output #3214

Closed
easirois opened this issue Feb 12, 2019 · 2 comments

Comments

Projects
2 participants
@easirois
Copy link
Contributor

commented Feb 12, 2019

Expected Behavior

The content in a topic has an @rev with an associated revprop value in a ditaval. In this case, the background for the content has a particular color associated with it. So I would expect the PDF to display the appropriate background color for the text in the PDF output.

Actual Behavior

The appriate color should be displayed for content within <tm> when @rev and revprop specified in a ditaval.

Possible Solution

Add call to commonattributes prior to base apply-template reference.

<fo:inline xsl:use-attribute-sets="tm">
			<xsl:call-template name="commonattributes"/>
			<xsl:apply-templates/>

Steps to Reproduce

Content:
<tm rev="test-new" status="new" tmtype="reg">Test</tm>

Ditaval:
<revprop action="flag" val="test-new" backcolor="#A6F28D" changebar="style:solid;width:1pt;offset:5pt;color:#A6F28D"/>

Copy of the error message, log file or stack trace

Environment

  • DITA-OT version: 2.3.1 to develop
  • Operating system and version:
    Window 10 x8664
  • How did you run DITA-OT?
    oXygen transformation scenario
  • Transformation type:
    PDF2
@easirois

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

working on submitting a pull request for this issue.

@robander

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Fixed with #3215

@robander robander closed this Feb 12, 2019

3.3 automation moved this from To do to Done Feb 12, 2019

robander added a commit that referenced this issue Feb 20, 2019

Fix for spaces in file/dir name #3214
Signed-off-by: Robert D Anderson <robander@us.ibm.com>

robander added a commit that referenced this issue Feb 20, 2019

Fix for spaces in file/dir name #3214
Signed-off-by: Robert D Anderson <robander@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.