Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrator class uses method not defined in "xml-apis-1.4.01.jar" #3272

Closed
raducoravu opened this issue Mar 29, 2019 · 1 comment

Comments

Projects
2 participants
@raducoravu
Copy link
Member

commented Mar 29, 2019

It uses this method "XMLInputFactory.newFactory()" which is defined in the JRE 1.8 default classes but is not defined in the similar implementation from "xml-apis-1.4.01.jar". Publishing probably works because the Java default classes are usually stronger than the extra JAR libraries from the classpath.
But when compiling the "dos.jar" if for example the compilation classpath favors "xml-apis-1.4.01.jar" instead of the runtime libraries, you get a compilation error.
I suggest replacing "newFactory()"=>"newInstance()" which does the same thing.

jelovirt added a commit that referenced this issue Mar 29, 2019

Use synonym method to get XML input factory #3272
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>

jelovirt added a commit that referenced this issue Mar 29, 2019

Merge pull request #3273 from dita-ot/feature/3272
Switch to use XML input factory method #3272

@jelovirt jelovirt added the bug label Mar 29, 2019

@jelovirt jelovirt added this to To do in 3.3.1 via automation Mar 29, 2019

@jelovirt jelovirt added this to the 3.3.1 milestone Mar 29, 2019

@jelovirt jelovirt moved this from To do to Done in 3.3.1 Mar 29, 2019

robander added a commit that referenced this issue Apr 2, 2019

Use synonym method to get XML input factory #3272
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Fixed by #3273

@jelovirt jelovirt closed this Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.