New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map-first preprocessing #2497

Merged
merged 62 commits into from Mar 13, 2017

Conversation

Projects
None yet
2 participants
@jelovirt
Member

jelovirt commented Oct 5, 2016

Change preprocessing to first process maps as far as possible and only then start processing topics. This simplifies the processing and allows combining modules, due to fewer process-order constraints.

  • combine gen-list and debug-filter into single target
  • separate map and topic processing
  • add new preprocess target
  • support topic start file
  • support filtering
  • support uplevels after cleanup

Signed-off-by: Jarno Elovirta jarno@elovirta.com

@jelovirt jelovirt self-assigned this Oct 5, 2016

@jelovirt

This comment has been minimized.

Show comment
Hide comment
@jelovirt

jelovirt Oct 6, 2016

Member

Plan is to first break everything, then make it pass tests, and then clean up. It would be nice to have very little code duplication, but in the end some code will probably be duplicated. Since this code is intended to be used to replace the old preprocessing pipe, the old code will be removed on the next major release.

Member

jelovirt commented Oct 6, 2016

Plan is to first break everything, then make it pass tests, and then clean up. It would be nice to have very little code duplication, but in the end some code will probably be duplicated. Since this code is intended to be used to replace the old preprocessing pipe, the old code will be removed on the next major release.

@jelovirt jelovirt added this to the 2.5 milestone Mar 13, 2017

@jelovirt jelovirt merged commit 00b4127 into dita-ot:develop Mar 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jelovirt

This comment has been minimized.

Show comment
Hide comment
@jelovirt

jelovirt Mar 13, 2017

Member

Moved enhancements to #2625 and #2626

Member

jelovirt commented Mar 13, 2017

Moved enhancements to #2625 and #2626

@mironovalexey

This comment has been minimized.

Show comment
Hide comment
@mironovalexey

mironovalexey Apr 28, 2017

Contributor

I suppose that map-first preprocessing will exclude topics, exploded by @chunk="by-topic",from reltables processing too.
Is this the expected result?

Contributor

mironovalexey commented Apr 28, 2017

I suppose that map-first preprocessing will exclude topics, exploded by @chunk="by-topic",from reltables processing too.
Is this the expected result?

@jelovirt jelovirt deleted the jelovirt:feature/map_first_preprocess branch Jul 8, 2017

@jelovirt jelovirt added preprocess2 and removed preprocess labels Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment