Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix for broken revprop processing #2749
If I have a revision that is set to
This occurs because when the flag module was updated to add typing to parameters and variables, two parameters for
Motivation and Context
The default start/end templates are there so that a process can add default start/end formatting (we've typically added a start-rev and end-rev graphic). By default they do nothing. Because the default parameters do not match the expected parameters, the whole module fails, and no flagging is added.
How Has This Been Tested?
This issue highlighted that we do not actually have any integration tests that use revision flags, so I've updated an existing test for
Type of Changes
In addition to the updated test case, this fix changes 4 instances of
An alternate fix would be to un-comment the sections that pass
The fix is intended for