New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use if and unless from Ant namespace #2890

Merged
merged 2 commits into from Feb 13, 2018

Conversation

Projects
2 participants
@jelovirt
Member

jelovirt commented Feb 3, 2018

Use @if:set and @unless:set instead of custom implementations of @if and @unless.

Signed-off-by: Jarno Elovirta jarno@elovirta.com

@jelovirt jelovirt added this to To Do in 3.1 via automation Feb 3, 2018

@jelovirt jelovirt moved this from To Do to In progress in 3.1 Feb 4, 2018

@jelovirt jelovirt moved this from In progress to Review in 3.1 Feb 4, 2018

@jelovirt jelovirt requested a review from robander Feb 4, 2018

@jelovirt jelovirt self-assigned this Feb 4, 2018

@robander

Looks good, and useful. I've been using these attributes in my own plugins since I was made aware of them.

@jelovirt jelovirt added this to the Next milestone Feb 13, 2018

jelovirt added some commits Feb 3, 2018

Use if and unless from Ant namespace
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Add DOTA014W to warn about use of deprecated @if or @unless
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>

@jelovirt jelovirt merged commit 19cfbcb into dita-ot:develop Feb 13, 2018

2 checks passed

DCO All commits have a DCO sign-off from the author
continuous-integration/travis-ci/pr The Travis CI build passed
Details

3.1 automation moved this from Review to Done Feb 13, 2018

@jelovirt jelovirt deleted the jelovirt:feature/if_else branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment