Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support key based linking from phrase-like elements #2961
Signed-off-by: Robert D Anderson firstname.lastname@example.org
Adds support for key based linking in PDF to phrase like elements that currently ignore the link.
Currently, a key resolves to a link target on
The following elements will pick up key text, but the link is ignored:
The proposed solution here moves that processing into a mode template so that it can be reused. Attributes are passed in with
In addition, topicmerge had to be updated to allow for
Motivation and Context
Originally reported by one of my customers, who was using
How Has This Been Tested?
Unit / integration tests pass, but that is expected because there is minimal testing for the merged / FO output.
Test case includes the following elements, which covers most phrase-like elements that take keyref; I think the only one I left out was
Type of Changes
Really a bug fix because this should always have worked, but treating it as a feature because it was a hole in core PDF functionality.
@raducoravu yes, that looks like the issue.
I started working on the issue as soon as my own customers reported it with
referenced this pull request
May 15, 2018
Generally speaking I don't like that add another layer of indirection to inline element processing, but this makes implementing linking elements easier.