Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop duplicate ID from dt #3180 #3185

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
3 participants
@robander
Copy link
Member

commented Jan 14, 2019

Signed-off-by: Robert D Anderson robander@us.ibm.com

Fixes #3180

Currently when processing <dt> we create a block, call <xsl:call-template name="commonattributes"/> (which adds language info and @id), then call the common processing for inline elements that can turn into links with a key. The common processing creates an fo:inline element and then calls <xsl:call-template name="commonattributes"/> again, resulting in a duplicate ID.

This update drops the ID from the block and keeps it on the inline element. Links to the ID still resolve correctly using the term text.

Drop duplicate ID from dt #3180
Signed-off-by: Robert D Anderson <robander@us.ibm.com>

@robander robander changed the base branch from develop to hotfix/3.2.2 Jan 15, 2019

@robander robander added this to the 3.2.2 milestone Jan 15, 2019

@robander robander merged commit 033ab8e into hotfix/3.2.2 Jan 28, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@robander robander deleted the hotfix/3180 branch Jan 28, 2019

@robander robander modified the milestones: 3.2.2, 3.3 Feb 20, 2019

@robander robander added this to In progress in 3.3 via automation Feb 20, 2019

@robander robander moved this from In progress to Done in 3.3 Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.