Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension points to contribute params to reader modules #3187

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
3 participants
@jelovirt
Copy link
Member

commented Jan 19, 2019

Add extension points to add parameters and filters to preprocess reader modules:

  • dita.preprocess.debug-filter.param
  • dita.preprocess.map-reader.param
  • dita.preprocess.topic-reader.param

Signed-off-by: Jarno Elovirta jarno@elovirta.com

Add extension points to contribute params to reader modules
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>

@jelovirt jelovirt added this to In progress in 3.3 via automation Jan 19, 2019

@jelovirt jelovirt moved this from In progress to Needs review in 3.3 Jan 19, 2019

@jelovirt jelovirt requested a review from robander Jan 19, 2019

@jelovirt jelovirt self-assigned this Jan 19, 2019

@jelovirt jelovirt modified the milestone: 3.3 Jan 21, 2019

3.3 automation moved this from Needs review to Reviewer approved Jan 21, 2019

@jelovirt jelovirt merged commit 0c03ee7 into develop Jan 21, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

3.3 automation moved this from Reviewer approved to Done Jan 21, 2019

@jelovirt jelovirt deleted the feature/reader-param-extension-point branch Jan 21, 2019

@jelovirt jelovirt added this to the 3.3 milestone Jan 21, 2019

@@ -51,6 +51,9 @@ See the accompanying LICENSE file for applicable license.
<!-- Deprecated since 2.1 -->
<extension-point id="depend.preprocess.copy-subsidiary.pre" name="Copy subsidiary pre-target"/>
<extension-point id="depend.preprocess.post" name="Preprocessing post-target"/>
<extension-point id="dita.preprocess.debug-filter.param" name="Debug filter module parameters"/>
<extension-point id="dita.preprocess.map-reader.param" name="Debug filter module parameters"/>
<extension-point id="dita.preprocess.topic-reader.param" name="Debug filter module parameters"/>

This comment has been minimized.

Copy link
@infotexture

infotexture Feb 25, 2019

Member

@jelovirt Looks like the latter two @name values are copy/paste errors.

If so, we could override these values in the docs, but it would be better to fix them at the source.

This comment has been minimized.

Copy link
@robander

robander Feb 25, 2019

Member

I saw that when approving this but thought it was intentional (now not sure if I was right) --

  • debug-filter.param adds params to the Ant debug-filter task in preprocess, which covers everything
  • map-reader.param adds params to map-reader, which does the initial parse / debug / filter of maps in preprocess2
  • topic-reader.param adds params to topic-reader, which does the initial parse / debug / filter of topics in preprocess2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.