Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preprocess clean with resource that have different URI scheme #3211

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
2 participants
@jelovirt
Copy link
Member

commented Feb 9, 2019

Preprocess clean module fails when input set has resources with different URI scheme, e.g. local files and external HTTPS files. This ignores the difference when calculating base directory.

Signed-off-by: Jarno Elovirta jarno@elovirta.com

@jelovirt jelovirt added this to In progress in 3.3 via automation Feb 9, 2019

Fix preprocess clean with resource that have different URI scheme
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>

@jelovirt jelovirt force-pushed the feature/preprocess-clean-different-scheme branch from 925e6b4 to cc6e6e9 Feb 9, 2019

@jelovirt jelovirt moved this from In progress to Needs review in 3.3 Feb 9, 2019

3.3 automation moved this from Needs review to Reviewer approved Feb 14, 2019

@jelovirt jelovirt merged commit 6194d62 into develop Feb 16, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

3.3 automation moved this from Reviewer approved to Done Feb 16, 2019

@jelovirt jelovirt added this to the 3.3 milestone Feb 16, 2019

@jelovirt jelovirt deleted the feature/preprocess-clean-different-scheme branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.