Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bar on table/fig should also appear in booklist #3235

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
2 participants
@robander
Copy link
Member

commented Feb 21, 2019

Signed-off-by: Robert D Anderson robander@us.ibm.com

This matches a change in 3.2 that added change bar support for revised topics in the TOC. #3100

This update does the same thing for tables and figures:

  • When a revision is specified on a table (or figure), AND
  • When that revision uses a change bar in the DITAVAL, AND
  • When that table (or figure)appears in a generated table list (or figure list),
  • The table (or figure) should be marked with that change bar in the table list (or figure list)
Change bar on table/fig should also appear in booklist
Signed-off-by: Robert D Anderson <robander@us.ibm.com>

@robander robander added this to In progress in 3.3 via automation Feb 21, 2019

@robander robander moved this from In progress to Needs review in 3.3 Feb 21, 2019

@robander

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

Sample bookmap for testing, with table/figure list, revised / not revised tables and figures, and ditaval:
pr3235.zip

3.3 automation moved this from Needs review to Reviewer approved Feb 23, 2019

@robander robander merged commit 03560eb into develop Feb 25, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

3.3 automation moved this from Reviewer approved to Done Feb 25, 2019

@robander robander deleted the hotfix/revTableFig branch Feb 25, 2019

@robander robander added this to the 3.3 milestone Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.