Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different DITA-OT installation volume and temp volume #3239

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
4 participants
@jelovirt
Copy link
Member

commented Feb 23, 2019

If DITA-OT installation directory and temporary directory are not on the same volume, simple Files.move will fail. Use Apache Commons IO to move directories.

Fixes #3162

Closes #3238

Support different DITA-OT installation volume and temp volume
If DITA-OT installation directory and temporary directory are not on the
same volume, simple Files.move will fail. Use Apache Commons IO to move
directories.

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>

@jelovirt jelovirt self-assigned this Feb 23, 2019

@jelovirt jelovirt added this to In progress in 3.3 via automation Feb 23, 2019

@jelovirt jelovirt requested a review from robander Feb 23, 2019

@jelovirt jelovirt referenced this pull request Feb 23, 2019

Closed

Bugfix issue 3162 #3238

@jelovirt jelovirt moved this from In progress to Needs review in 3.3 Feb 23, 2019

@hcw70

This comment has been minimized.

Copy link

commented Feb 25, 2019

I would propose a higher priority here, since

  • The bug affects many people (All people running on *nix like systems with a "normal" file system layout, where /tmp and /usr are on different file systems).
  • The effect is that none of those people can install a plugin with the "dita" command.

3.3 automation moved this from Needs review to Reviewer approved Feb 25, 2019

@infotexture infotexture added this to the 3.3 milestone Feb 27, 2019

@jelovirt jelovirt merged commit 857bee8 into develop Feb 27, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

3.3 automation moved this from Reviewer approved to Done Feb 27, 2019

@jelovirt jelovirt deleted the feature/pluing-install-different-volume branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.