Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate conref target message #3248

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
3 participants
@robander
Copy link
Member

commented Mar 5, 2019

Signed-off-by: Robert D Anderson robander@us.ibm.com

Currently, if there are two possible targets when processing @conref, DITA-OT throws this error:
[conref] file:/C:/DITA-OT/dita-ot-3.2.1/docsrc/samples/concepts/garageconceptsoverview.xml:12:23: [DOTX011W][WARN]: There is more than one possible target for the reference conref="". Only the first will be used. Removethe duplicate id in the referenced file.

The actual conref value is missing because at some point in a past release, the context from which this error is called changed. The context in this pull request is $target-doc, which is the root element of the document that contains the target of the conref.

This update fixes the message by moving the context back to the $current-element context that already exists, so the message includes the conref value again:
[conref] file:/C:/DITA-OT/dita-ot-3.2.1/docsrc/samples/concepts/garageconceptsoverview.xml:12:23: [DOTX011W][WARN]: There is more than one possible target for the reference conref="#taskconcept/p". Only the first will be used. Removethe duplicate id in the referenced file.

Fix duplicate conref target message
Signed-off-by: Robert D Anderson <robander@us.ibm.com>

@jelovirt jelovirt added this to In progress in 3.3.1 via automation Mar 6, 2019

@robander robander moved this from In progress to Needs review in 3.3.1 Mar 6, 2019

3.3.1 automation moved this from Needs review to Reviewer approved Mar 9, 2019

@robander robander merged commit f9d06c9 into hotfix/3.3.1 Apr 2, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

3.3.1 automation moved this from Reviewer approved to Done Apr 2, 2019

@robander robander deleted the hotfix/conrefMsg branch Apr 2, 2019

@infotexture infotexture added this to the 3.3.1 milestone Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.