Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin param types #3251

Merged
merged 2 commits into from Apr 6, 2019

Conversation

Projects
3 participants
@jelovirt
Copy link
Member

commented Mar 9, 2019

Fix param types in plugin configuration where type file is incorrectly used. The type file should only be applied to arguments that are system paths that take either an absolute path, or relative path that can be made absolute by resolving with some base base that is not part of input set. The same restriction applies to dir type. For params that represent paths but are e.g. relative to input set or output set, should use string type.

jelovirt added some commits Mar 9, 2019

Fix transtype param type to string
The actual type of the transtype param is actually an enum, but the
value space is not known at compile time, so we use string.

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Fix css params' type to be string
Because the css params can have relative paths as values, the correct
param type is string.

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>

@jelovirt jelovirt self-assigned this Mar 9, 2019

@jelovirt jelovirt added this to In progress in 3.3.1 via automation Mar 9, 2019

@jelovirt jelovirt requested a review from robander Mar 9, 2019

@jelovirt jelovirt moved this from In progress to Needs review in 3.3.1 Mar 9, 2019

3.3.1 automation moved this from Needs review to Reviewer approved Apr 4, 2019

@jelovirt jelovirt merged commit b881621 into hotfix/3.3.1 Apr 6, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

3.3.1 automation moved this from Reviewer approved to Done Apr 6, 2019

@jelovirt jelovirt deleted the feature/fix-plugin-param-types branch Apr 6, 2019

@jelovirt jelovirt added this to the 3.3.1 milestone Apr 6, 2019

@raducoravu

This comment has been minimized.

Copy link
Member

commented on 8851e33 May 20, 2019

We use the type of the parameter in order to know how to edit them in the user's interface. For example if the type is "file" we present a file chooser next to the parameter value which allows browsing for it. Because the type was changed to "string" we can no longer present the file chooser for these three parameters without hard-coding some behavior based only on their names.
Ideally it would have been better to create a new type value like "relative-uri" or "relative-file".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.