Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated string 'continued' #3310

Merged
merged 1 commit into from May 23, 2019

Conversation

Projects
2 participants
@robander
Copy link
Member

commented May 21, 2019

Signed-off-by: Robert D Anderson robander@us.ibm.com


name: Pull request
about: Propose changes to fix an issue or implement a new feature


Description

Fixes two TODO instances where a set of translated strings each has English for the string "continued"; also adds the string "continued" for the two remaining sets that have no translation for that string.

Motivation and Context

We recently started using this string in our PDF styles, and found it was broken / empty for these four languages.

How Has This Been Tested?

Validated as part of our own style - with these updates in place, the "continued" string appears correctly for all languages.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
Fix generated string 'continued'
Signed-off-by: Robert D Anderson <robander@us.ibm.com>

@robander robander added this to In progress in 3.3.2 via automation May 21, 2019

@robander robander removed this from In progress in 3.3.2 May 21, 2019

@robander robander added this to In progress in 3.3.2 via automation May 21, 2019

@robander robander moved this from In progress to Review in progress in 3.3.2 May 21, 2019

3.3.2 automation moved this from Review in progress to Reviewer approved May 23, 2019

@robander robander merged commit 0873150 into dita-ot:hotfix/3.3.2 May 23, 2019

3 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

3.3.2 automation moved this from Reviewer approved to Done May 23, 2019

@robander robander deleted the robander:fixGentext branch May 23, 2019

@robander robander added this to the 3.3.2 milestone May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.