Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details for DOTJ070I, DOTJ071E, tweak DOTJ030I #141

Merged
merged 1 commit into from May 3, 2017

Conversation

robander
Copy link
Member

@robander robander commented May 2, 2017

These updates go with changes in dita-ot/dita-ot#2637 and dita-ot/dita-ot#2569 for DITA-OT 2.5.

@robander robander added this to the 2.5 milestone May 2, 2017
@robander robander requested a review from infotexture May 2, 2017 19:49
Copy link
Member

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

I'll merge as is & tweak these bits afterwards.

@@ -198,7 +198,7 @@
<strow>
<stentry conref="DITA-messages.xml#msgs/DOTJ030I-extra" conaction="pushreplace">All specialized DITA elements
must define a class attribute to provide ancestry information. This message will only appear if a specialized
DITA element did not define a class attribute.</stentry>
DITA element did not define a class attribute, or if non-DITA elements are included in a DITA context..</stentry>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: extra period at the end of the sentence

<stentry conref="DITA-messages.xml#msgs/DOTJ071E-extra" conaction="pushreplace">
<p>Ensure that the DITAVAL file exists. If more than one DITAVAL file is specified, ensure that
the paths are separated using the separator character appropriate for your operating system
(semicolon <codeph>;</codeph> on Windows, or colon <codeph>:</codeph> on Mac or Linux).</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac → macOS

@infotexture infotexture merged commit 34cb0be into develop May 3, 2017
@infotexture infotexture added the enhancement Changes to an existing topic or feature label May 3, 2017
@infotexture infotexture added this to Done in 2.5 Release May 3, 2017
@infotexture infotexture deleted the new-messages branch May 3, 2017 13:43
infotexture added a commit that referenced this pull request May 3, 2017
Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request May 3, 2017
* Mac → macOS
* Linux before macOS

Signed-off-by: Roger Sheen <roger@infotexture.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes to an existing topic or feature
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants