Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Video : typo in source type ? #37

Closed
Jerome-github opened this Issue · 5 comments

3 participants

@Jerome-github

Hi.

I'm afraid there's a little typo here :

http://diveintohtml5.info/video.html

<source src="pr6.webm" type="video/webm; codecs=vp8, vorbis" />
<source src="pr6.ogv" type="video/ogg; codecs="theora, vorbis" />

Shouldn't it look like this ?

type='video/webm; codecs="vp8, vorbis"'

I had issues with type="video/webm; codecs=vp8, vorbis" using firefox.

Jérôme

@estebanav estebanav referenced this issue from a commit
@estebanav estebanav - Video : typo in source type ? - Issue #37
- Broken links for video encoding and formats in 'Detecting HTML5 features' chapter - Issue #31

Signed-off-by: Esteban Acosta <estebanav@gmail.com>
71d3452
@estebanav

Hi Jerome!

Actually, the problem here is the extra double quote on type attribute just follow codecs=:

source src="pr6.ogv" type="video/ogg; codecs="theora, vorbis"

I've just removed it and formatted the type attribute per W3C specs that specify multiple codecs must be wrapped by a single quote (')

http://www.w3.org/TR/2008/WD-html5-20080122/#the-source

Thanks!

@paulirish and @jonathantneal

These changes are ready to be pulled if you accept them.

Thanks!

@jonathantneal
Collaborator

@estebanav, where does it say the single quote is required? Have you checked to see if this works cross browser? I believe the problem was only the extra double quote, which appears to have already been fixed in another update (viewing the source of the page).

@Jerome-github
@estebanav

@jonathantneal

where does it say the single quote is required?

In the following link to W3C HTML5's Specs the codecs attribute appear enclosed by double-quotes, so I assumed that multiple attributes within an attribute must be wrapped by single or double quotes.

http://www.w3.org/html/wg/drafts/html/master/embedded-content-0.html#the-source-element

Have you checked to see if this works cross browser?

Yes, I did it :)

@Jerome-github

I think the problem is the extra double quote that is broken the HTML and that's why FF is not rendering correctly and codecs might be wrapped by single or double quotes as I wrote above.

@jonathantneal jonathantneal referenced this issue from a commit
@estebanav estebanav - Video : typo in source type ? - Issue #37
- Broken links for video encoding and formats in 'Detecting HTML5 features' chapter - Issue #31

Signed-off-by: Esteban Acosta <estebanav@gmail.com>
3bfde37
@jonathantneal
Collaborator

The typo was in my repository. I am so close to having them in sync. It should be corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.