Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Essentially reverts #144 #187

Merged
merged 1 commit into from
Apr 20, 2015
Merged

Essentially reverts #144 #187

merged 1 commit into from
Apr 20, 2015

Conversation

mkoistinen
Copy link
Contributor

We no longer wish to swallow NoReverseMatch exceptions for anything that happens in get_absolute_url.

We no longer wish to swallow NoReverseMatch exceptions for anything that happens in get_absolute_url.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.52% when pulling 2d6dd7d on issues/reverse_pr_145 into 959d60c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 92.52% when pulling 2d6dd7d on issues/reverse_pr_145 into 959d60c on master.

@stefanfoulis
Copy link
Contributor

How will this behave the first time you startup the app and don't have the apphook setup yet? I think that chicken/egg problem was the original reason for this.

@chronossc
Copy link
Contributor

LGTM.

@mkoistinen
Copy link
Contributor Author

@stefanfoulis Yes, #144 (the commit this essentially reverses) was to allow work-flows where people create articles for display in plugins before the blog page they belong to was actually apphook'ed.

I think we need another way to solve that. Perhaps by restricting the creation of Articles until the appconfig they use is "valid", which would be determined by having a published apphook'ed page.

mkoistinen added a commit that referenced this pull request Apr 20, 2015
@mkoistinen mkoistinen merged commit 801b626 into master Apr 20, 2015
@mkoistinen mkoistinen deleted the issues/reverse_pr_145 branch April 20, 2015 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants