two infinite loops #1019

Closed
lauxley opened this Issue Sep 19, 2011 · 2 comments

Comments

Projects
None yet
3 participants

lauxley commented Sep 19, 2011

One can argue that it is a case of bad use of the framework, but as it is supposed to be used by regular users (not computer nerds) i think these are still issues.

  • when i select the page i am editing in a "Inherit plugins from page" plugin.
  • when i redirect a page to itself (in the "redirect" field in advanced settings).

there may be more, those 2 are the only ones my user could "find out".

I think the page shouldn't be in the options in the first case.
The second is maybe a bit trickier, but a form error would be nice.

Collaborator

chrisglass commented Sep 19, 2011

I think it's a very valid complaint.

Collaborator

ojii commented Oct 14, 2011

I could reproduce the 'redirect' issue but not the 'inherit plugins from page' issue.

@ojii ojii pushed a commit to ojii/django-cms that referenced this issue Oct 14, 2011

Jonas Obrist Started working on #1019, it should prevent the issue in most cases,
however it's really insanely hard to cover edge-cases (especially for
home-pages) since it's not trivial to check if a page will be the
homepage or not.
bf448a1

ojii referenced this issue Oct 14, 2011

Closed

Fix/1019 #1053

@ojii ojii pushed a commit to ojii/django-cms that referenced this issue Oct 18, 2011

Jonas Obrist added test for #1019 ea1aaec

@ojii ojii pushed a commit to ojii/django-cms that referenced this issue Oct 18, 2011

Jonas Obrist added fix for #1019.
This fix is done by ignoring redirects to self
Fixes #1019
845d263

ojii referenced this issue Oct 18, 2011

Merged

Fix 1019 2 #1061

ojii closed this in 845d263 Oct 19, 2011

ojii closed this in 2b6c7e2 Oct 19, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment