Page permission inconsistencies #1430

Closed
kux opened this Issue Sep 19, 2012 · 2 comments

Projects

None yet

4 participants

@kux

When changing a user using 'Change User (page) ' form, you can set the user's 'Add', 'Change' , 'Delete' Page permissions.
In the meanwhile, the 'Page permissions' formset on any page has the following checkboxes: 'Can edit', 'Can add', 'Can delete' which overlap with the functionality of the three permissions above.

The problem with this is that you can make strange combinations:

  • disable 'Add' on the 'Change User (page); form, but enable 'Can add' on a page's 'Page permissions' formset
    => the user will continue having the 'Add child' button active on the 'actions' column in the page hierarchy webpage, even though 'Add' is disabled for that user. I would have expected that the user has a certain permission if the permission is ticked in both 'User (page)' form and 'Page permissions' formset

  • disable 'Delete' on the 'Change User (page); form, but enable 'Can delete' on a page's 'Page permissions' formset
    => the user will NO LONGER have the 'Delete' button active on the 'actions' column in the page hierarchy. This behavior is as I would have expected, but it's inconsistent with the behavior above.

I think the best solution would be:

  • If the user doesn't have a page permission set in the 'Change user (page)' form, then simply disable the corresponding tickbox in a page's 'Page permissions' formset
@kux

Reproduced on django-cms: 35f76b0

@yakky yakky modified the milestone: 3.0.X, 3.0 May 1, 2014
@yakky yakky modified the milestone: 3.0.X, 3.0.6 Oct 1, 2014
@yakky yakky modified the milestone: 3.0.X, 3.X Oct 17, 2014
@FinalAngel FinalAngel referenced this issue Oct 20, 2015
Open

[META] Page permission refactor #4598

2 of 10 tasks complete
@FinalAngel
Divio AG member

Closed in favour of #4598

@FinalAngel FinalAngel closed this Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment