Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Plugin cancel button doesn't work when using a PlaceholderField with a custom model #1452

Closed
kux opened this Issue Sep 27, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

kux commented Sep 27, 2012

This is related to: #1124

The fix works great when using the cancel button for a plugin within the page, but the issue still reproduces when a PlaceholderField is used in custom models (see: http://docs.django-cms.org/en/2.3/extending_cms/placeholders.html)

Contributor

kux commented Sep 27, 2012

There's a lot of duplicated logic between plugin handling code in pageadmin.py and placeholderadmin.py and I think it's quite easy to fix one and forget about the other.

Member

digi604 commented Oct 4, 2012

fixed with #1461

@digi604 digi604 closed this Oct 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment