More explanation on how to run tests is required #1535

Closed
evildmp opened this Issue Nov 25, 2012 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

evildmp commented Nov 25, 2012

The Contributing to django CMS section just says:

To run the tests simply execute python setup.py test from your shell.

but in fact it's not that simple.

Anyone submitting patches/tests needs to run tests for Pythons 2.5-2.7, and Djangos 1.3 to trunk - otherwise, unexpected issues can slip through (#1532 (comment)).

Also, there's the distinction between ./runtests.py and python setup.py test, the question how to install all appropriate requirements before testing, and so on.

Some expansion of the section to cover this would be really useful for contributors, and improve the quality of pull requests.

evildmp added a commit to evildmp/django-cms that referenced this issue Dec 10, 2012

evildmp added a commit to evildmp/django-cms that referenced this issue Dec 10, 2012

evildmp added a commit to evildmp/django-cms that referenced this issue Dec 10, 2012

digi604 added a commit that referenced this issue Dec 12, 2012

Merge pull request #1553 from evildmp/1535-contribution-docs
address #1535 docs on contribution and testing
Contributor

digi604 commented Jul 11, 2013

seams to be fixed

@digi604 digi604 closed this Jul 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment