Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

django-1.5: ModelAdmin.get_inline_instances() signature changed #1609

Closed
stefanfoulis opened this issue Jan 23, 2013 · 2 comments · Fixed by #1674
Closed

django-1.5: ModelAdmin.get_inline_instances() signature changed #1609

stefanfoulis opened this issue Jan 23, 2013 · 2 comments · Fixed by #1674

Comments

@stefanfoulis
Copy link
Contributor

since django-1.5 the object needs to be passed in. This problem surfaces when adding new cms pages.
@quantumfusion
Copy link

Just want to point out that someone has started work to solve this, but ran into an infinite recursion problem:
#1568

kux added a commit to kux/django-cms that referenced this issue Feb 28, 2013
@kux
Fix for django-cms#1609 Adapt to new signature of get_inline_instance…
f0b38d6 
…s but also keep backwards compatibility with django 1.4
@kux kux mentioned this issue Feb 28, 2013
Closed
kux added a commit to kux/django-cms that referenced this issue Feb 28, 2013
@kux
Fix for django-cms#1609 - backwards compatibility for django 1.3 as well
fe6f6fd
kux added a commit to kux/django-cms that referenced this issue Feb 28, 2013
@kux
Fix for django-cms#1609 - backwards compatibility for django 1.3 as w…
f560aa4 
…ell (set _current_page)
bikeshedder pushed a commit to bikeshedder/django-cms that referenced this issue Mar 26, 2013
@kux @bikeshedder
Fix for django-cms#1609 Adapt to new signature of get_inline_instance…
f52d730 
…s but also keep backwards compatibility with django 1.4
@bikeshedder bikeshedder mentioned this issue Mar 26, 2013
Merged
@digi604
Copy link
Contributor

digi604 commented Mar 27, 2013

fixed in #1674

@digi604 digi604 closed this as completed Mar 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Django 1.5 - All unit tests pass for Django 1.4 and 1.5. bikeshedder/django-cms
3 participants
@stefanfoulis @digi604 @quantumfusion