Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Python 3k prerequisite status #1632

Closed
xordoquy opened this Issue · 15 comments

6 participants

@xordoquy

Here's a list of packages on which django CMS depends on:

  • Django (ready, 1.5),
  • django-classy-tags (ready, already in use in cms 2.4)
  • south>=0.7.2 (ready, trunk)
  • html5lib (ready in master branch)
  • django-mptt (ready in master branch)
  • django-sekizai (ready, already in use in cms 2.4)
  • django-reversion (support added in 1.7)
  • Pillow (support added in 2.0)

Here's the list of packages needed by the tests/docs:

  • Sphinx (ready, 1.1.3)
  • Jinja2 (ready, 2.6)
  • Pygments (ready, 1.6)
  • dj-database-url
  • django-hvad (master branch on github, release pending)
  • djangocms-text-ckeditor (master branch on github, release pending)
  • djangocms-style (master branch, release pending)
@ojii
Collaborator
@xordoquy

Thanks Jonas, updated.

@ojii
Collaborator

Also, sphinx, jinja2 and pygments are only used in development and are therefore not required for an eventual py3 port .

@ojii
Collaborator

Took the liberty to edit OP with nicer formatting.

@ojii
Collaborator

updated OP, looks like only html5lib and mptt are missing

@gsnedders

The html5lib bug only affects parse.py, which is a script (that isn't even in the source distribution, let alone installed); the library itself runs fine under Python 3 (at least in terms of what is in git; the latest release doesn't).

@craigds

FYI just merged python 3 support into mptt master.

@ojii
Collaborator

@craigds amazing! I'd appreciate it if you could post in this thread again when you make a Py3 compatible release so we know what version we have to develop against.

@craigds

Will do :)

@ojii
Collaborator

Okay so after checking html5lib it looks like all dependencies are Python3 ready now (at the very least in their respective repositories).

@ojii
Collaborator

Sorry for the excitement. It looks like for some reason our tests now depend on django-hvad which is not Py3 ready.

@ojii
Collaborator

My branch adding Python 3 support:

https://github.com/ojii/django-cms/commits/toolbar-3000

Note that it requires a lot of dependencies directly from github, and djangocms-text-ckeditor needs to be from my branch. Also I had to merge #1917 into this as too many of the toolbar tests failed.

I'll keep this branch up to date until the dependencies have releases.

EDIT: Note that tests currently fail on Python 2, will look into that.
EDIT2: Tests pass again under 2.7 and 3.3.

@yakky
Collaborator

I guess we can close this

@craigds

I've just tagged mptt 0.6.rc1 which has that py3 support in it : https://github.com/django-mptt/django-mptt/tree/0.6.rc1

Please test with django-cms , if it's okay I'll be tagging 0.6.0 in a week or so.

@digi604
Collaborator

closing as we have passing tests.

@digi604 digi604 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.