NoReverseMatch raised if apphook doesn't exist #1649

Closed
Lacrymology opened this Issue Mar 8, 2013 · 1 comment

Projects

None yet

3 participants

@Lacrymology

when I add an app to INSTALLED_APPS that defines menu entries which in turn call reverse() to get some urls, I get NoReverseMatch errors if there's no Page apphooked to that app, even though I don't see why that menu shoud be being processed.

I'm seeing this with cmsplugin_zinnia, I'm not sure if this is a cmsplugin_zinnia or a django-cms issue

@Lacrymology Lacrymology referenced this issue in django-blog-zinnia/cmsplugin-zinnia Mar 24, 2013
Closed

NoReverseMatch raised if blog apphook doesn't exist #12

@vskh

Experienced the same with cmsplugin_news.

@spillevink spillevink added a commit to spillevink/django-cms that referenced this issue Aug 8, 2013
@spillevink spillevink Fixing #1649 - NoReverseMatch raised if apphook doesn't exist
Some apps, like cmsplugin-zinnia and cmsplugin_news will raise NoReverseMatch when trying to generate their menus before an apphook is installed. In sampleapp this is solved by adding a try-except like the one in this commit. Placing the try-except in django-cms instead of inside every app would simplify the process of writing plugins and avoid some confusing 500-errors for new users trying to install plugins.
3eb2010
@yakky yakky added a commit to yakky/django-cms that referenced this issue Sep 19, 2013
@spillevink spillevink Fixing #1649 - NoReverseMatch raised if apphook doesn't exist
Some apps, like cmsplugin-zinnia and cmsplugin_news will raise NoReverseMatch when trying to generate their menus before an apphook is installed. In sampleapp this is solved by adding a try-except like the one in this commit. Placing the try-except in django-cms instead of inside every app would simplify the process of writing plugins and avoid some confusing 500-errors for new users trying to install plugins.
38565f0
@yakky yakky added a commit to yakky/django-cms that referenced this issue Nov 19, 2013
@spillevink spillevink Fixing #1649 - NoReverseMatch raised if apphook doesn't exist
Some apps, like cmsplugin-zinnia and cmsplugin_news will raise NoReverseMatch when trying to generate their menus before an apphook is installed. In sampleapp this is solved by adding a try-except like the one in this commit. Placing the try-except in django-cms instead of inside every app would simplify the process of writing plugins and avoid some confusing 500-errors for new users trying to install plugins.
140b575
@yakky yakky added a commit to yakky/django-cms that referenced this issue Nov 20, 2013
@spillevink spillevink Fixing #1649 - NoReverseMatch raised if apphook doesn't exist
Some apps, like cmsplugin-zinnia and cmsplugin_news will raise NoReverseMatch when trying to generate their menus before an apphook is installed. In sampleapp this is solved by adding a try-except like the one in this commit. Placing the try-except in django-cms instead of inside every app would simplify the process of writing plugins and avoid some confusing 500-errors for new users trying to install plugins.
6ba4539
@digi604 digi604 closed this in #2234 Nov 25, 2013
@Lacrymology Lacrymology added a commit to Lacrymology/django-cms that referenced this issue Aug 21, 2014
@spillevink spillevink Fixing #1649 - NoReverseMatch raised if apphook doesn't exist
Some apps, like cmsplugin-zinnia and cmsplugin_news will raise NoReverseMatch when trying to generate their menus before an apphook is installed. In sampleapp this is solved by adding a try-except like the one in this commit. Placing the try-except in django-cms instead of inside every app would simplify the process of writing plugins and avoid some confusing 500-errors for new users trying to install plugins.
07b5d55
@Lacrymology Lacrymology added a commit to Lacrymology/django-cms that referenced this issue Aug 21, 2014
@Lacrymology Lacrymology Merge branch 'pr2156-backport' into production
* pr2156-backport:
  That was a stupid error
  Reword the error message and log the error.
  Limits messages to staff users only
  Add messages when apphook raises exception in menu
  Fixing #1649 - NoReverseMatch raised if apphook doesn't exist
b1b5e71
@Lacrymology Lacrymology added a commit to Lacrymology/django-cms that referenced this issue Aug 21, 2014
@Lacrymology Lacrymology Merge branch 'pr2156-backport' into production
* pr2156-backport:
  Revert settings from "Reword the error message and log the error."
  Reword the error message and log the error.
  Limits messages to staff users only
  Add messages when apphook raises exception in menu
  Fixing #1649 - NoReverseMatch raised if apphook doesn't exist
22fc0d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment