CMS messages and Django messages #2020

Closed
andreif opened this Issue Jul 10, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@andreif
Contributor

andreif commented Jul 10, 2013

I am not sure that using Django's messages for CMS is a good idea since they get rendered in two places -- by CMS toolbar and in site templates.

What was the reasoning behind using them?

@digi604

This comment has been minimized.

Show comment Hide comment
@digi604

digi604 Jul 10, 2013

Contributor

They where already there? 😄 Better idea?

Contributor

digi604 commented Jul 10, 2013

They where already there? 😄 Better idea?

@andreif

This comment has been minimized.

Show comment Hide comment
@andreif

andreif Jul 10, 2013

Contributor

Sadly there is no namespacing in messages, so one have to build similar logic inside cms. It is a little code though. Cms can use its own middleware and context processor to enable it.

Contributor

andreif commented Jul 10, 2013

Sadly there is no namespacing in messages, so one have to build similar logic inside cms. It is a little code though. Cms can use its own middleware and context processor to enable it.

@digi604

This comment has been minimized.

Show comment Hide comment
@digi604

digi604 Jul 10, 2013

Contributor

would you write it?

tumblr_inline_mhced34kw01qz4rgp

Contributor

digi604 commented Jul 10, 2013

would you write it?

tumblr_inline_mhced34kw01qz4rgp

@andreif

This comment has been minimized.

Show comment Hide comment
@andreif

andreif Jul 10, 2013

Contributor

It's hard to say no...

Contributor

andreif commented Jul 10, 2013

It's hard to say no...

@digi604 digi604 added this to the Some Day milestone Feb 10, 2014

@FinalAngel

This comment has been minimized.

Show comment Hide comment
@FinalAngel

FinalAngel Oct 19, 2015

Owner

We are still successfully using the django messaging system and there is Cl.API.Message() to open a message within the toolbar

Owner

FinalAngel commented Oct 19, 2015

We are still successfully using the django messaging system and there is Cl.API.Message() to open a message within the toolbar

@FinalAngel FinalAngel closed this Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment