Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

default apphook namespace #2612

Closed
stefanfoulis opened this Issue · 2 comments

3 participants

@stefanfoulis

If a apphook needs namespaces it, it should be able define the default instance namespace (see django url namespacing) on the Apphook class.
Since the namespace field is unique, form validation will complain if the namespace is already taken. Otherwise the default can silently be used.

In advanced settings:
screen shot 2014-02-10 at 2 15 56 pm

@digi604 digi604 modified the milestone: 3.0
@mkoistinen
Collaborator

Django docs that I think @stefanfoulis meant to reference: https://docs.djangoproject.com/en/dev/topics/http/urls/#reversing-namespaced-urls

tl:dr
“The default application instance is the instance that has an instance namespace matching the application namespace...”

@mkoistinen mkoistinen closed this
@mkoistinen mkoistinen reopened this
@mkoistinen
Collaborator

This is implemented, but slightly differently. It doesn't not affect the presentation of the form, but if the user neglects to complete the 'Application instance name[space]:' field, and the app requires one, and the default is not already in use, then it will just automatically apply the default.

The next time the user inspects the Advanced Settings form, they will see it was set.

@mkoistinen mkoistinen closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.