Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

default apphook namespace #2612

Closed
stefanfoulis opened this Issue Feb 10, 2014 · 2 comments

Comments

Projects
None yet
3 participants
Owner

stefanfoulis commented Feb 10, 2014

If a apphook needs namespaces it, it should be able define the default instance namespace (see django url namespacing) on the Apphook class.
Since the namespace field is unique, form validation will complain if the namespace is already taken. Otherwise the default can silently be used.

In advanced settings:
screen shot 2014-02-10 at 2 15 56 pm

@digi604 digi604 modified the milestone: 3.0 Feb 11, 2014

Collaborator

mkoistinen commented Mar 28, 2014

Django docs that I think @stefanfoulis meant to reference: https://docs.djangoproject.com/en/dev/topics/http/urls/#reversing-namespaced-urls

tl:dr
“The default application instance is the instance that has an instance namespace matching the application namespace...”

@mkoistinen mkoistinen added a commit that referenced this issue Mar 29, 2014

@mkoistinen mkoistinen Merge pull request #2984 from mkoistinen/use_default_instance_namespace
Address #2612 - Use default instance namespace
ce4b3e3

@mkoistinen mkoistinen closed this Mar 29, 2014

@mkoistinen mkoistinen reopened this Mar 29, 2014

Collaborator

mkoistinen commented Mar 29, 2014

This is implemented, but slightly differently. It doesn't not affect the presentation of the form, but if the user neglects to complete the 'Application instance name[space]:' field, and the app requires one, and the default is not already in use, then it will just automatically apply the default.

The next time the user inspects the Advanced Settings form, they will see it was set.

@mkoistinen mkoistinen closed this Mar 29, 2014

@mkoistinen mkoistinen added a commit that referenced this issue Mar 31, 2014

@mkoistinen mkoistinen Merge pull request #2989 from mkoistinen/smarter_app_hook_ui
Smarter app hook ui (related to issue #2612)
f90804a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment