Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Plugins are not available by default if not defined in CMS_PLACEHOLDER_CONF #2705

Closed
worseisbetter opened this Issue Feb 24, 2014 · 13 comments

Comments

Projects
None yet
6 participants
@ghost

ghost commented Feb 24, 2014

Generic plugins are not available by default, only if defined in CMS_PLACEHOLDER_CONF. Had to define a CMS_PLACEHOLDER_CONF with the Text plugin to make it show up. Version is b4.dev7

centralniak pushed a commit to centralniak/django-cms that referenced this issue Feb 24, 2014

Member

digi604 commented Feb 26, 2014

sure?

@digi604 digi604 added this to the 3.0 milestone Feb 26, 2014

@ghost

ghost commented Feb 26, 2014

definitly, i have filer and text installed and if no CMS_PLACEHOLDER_CONF was defined, i only see those plugins, not the text plugin.

Member

digi604 commented Feb 28, 2014

with current develop i removed CMS_PLACEHOLDER_CONF from settings and created a page and i can add all installed plugins.

Member

digi604 commented Feb 28, 2014

with only 'djangocms_text_ckeditor', and 'filer',
'cmsplugin_filer_file',
'cmsplugin_filer_folder',
'cmsplugin_filer_image',
'cmsplugin_filer_teaser',
'cmsplugin_filer_video', installed.... i get the same result.

Contributor

tanderegg commented Feb 28, 2014

This is my setup too, with djangocms_text_ckeditor, filer, etc., and I've never had CMS_PLACEHOLDER_CONF defined, yet all plugins are available.

@ghost

ghost commented Feb 28, 2014

sorry, the problem is with cmsplugin_cascade, i had it installed too. removing it fixed it.

@ghost ghost closed this Feb 28, 2014

Contributor

jrief commented Feb 28, 2014

I just did a test. In settings:

INSTALLED_APPS = (
    'django.contrib.auth',
    'django.contrib.contenttypes',
    'django.contrib.sessions',
    'django.contrib.sites',
    'djangocms_admin_style',
    'django.contrib.messages',
    'django.contrib.admin',
    'django.contrib.staticfiles',
    'django.contrib.sitemaps',
    'djangocms_text_ckeditor',
    'cmsplugin_cascade',
    'cms',
    'menus',
    'mptt',
    'south',
    'filer',
    'easy_thumbnails',
    'djangocms_link',
    'cmsplugin_filer_file',
    'cmsplugin_filer_folder',
    'cmsplugin_filer_image',
    'sekizai',
    'bootstrap3', # this is from my example code
)

CMS_PLACEHOLDER_CONF is not defined.

CMS_CASCADE_PLUGINS = ('bootstrap3',) # required if cmsplugin_cascade in INSTALLED_APPS

According to the bug description, no generic plugins are visible. But I can't reproduce this, if I do a test, all plugins from section Filer and Generic can be added.

Could someone please retest using the latest version of cmsplugin_cascade.

@ghost

ghost commented Feb 28, 2014

ok, not your plugin, coincidence. it's the actual number of entry's in the drop down. on osx there are no vertical scrollbars visible by default. only if you try to scroll something or reach the end. the drop down unfortunately doesn't scroll down if you reach the last visible entry with mouseover. so if you don't know there could be more entry's in this dropdown and you try scrolling you won't see them. perhaps it's just me, but i guess it would be a much better design decision to not at all limit this drop down in it's height. Or implement some event which autoscrolls the list a element down if you reach the last entry. But1st would be easier and i think that is the standard ui solution for such things, so a user sees all possible entrys at once. guess that's what fooled me. i could provide a pull request for both scenarios.

@ghost ghost reopened this Feb 28, 2014

@digi604 digi604 added the frontend label Mar 1, 2014

Member

digi604 commented Mar 1, 2014

so this is only a frontend ui issue? People don't see that there are more plugins in the dropdown?

@ghost

ghost commented Mar 1, 2014

yes, sorry for my stupidity. but probably i won't be the only one running into this

@ghost

ghost commented Mar 1, 2014

The simple fix is to remove max-height:230px; in .cms_submenu-dropdown in _subnav.scss.
But i'm not sure if this is by intention as the list could get too big? A more beautiful solution would be perhaps to add a second level for the plug categories which expand on mouseover (more like a accordion). I'll look into the last option today, guess that would be a nice ux.

johnraz added a commit to johnraz/django-cms that referenced this issue Mar 3, 2014

Contributor

johnraz commented Mar 3, 2014

Just adding my 2 cents:
I totally agree that this is confusing but I don't think that an accordion would improve the ux, the quicksearch feature is already the best you can get.

What I would do instead is add a small hint box at the bottom of the submenu that would disappear as soon as you scroll.

I did a proof of concept here #2777

Owner

FinalAngel commented Mar 3, 2014

You can force scrollbars on overflow elements using css3. I'll check with #2705 and try to find a solution.

@FinalAngel FinalAngel self-assigned this Mar 3, 2014

@FinalAngel FinalAngel closed this in cc70db0 Mar 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment