New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contextual menu not working when alias present on the same page #5382
Comments
It is a known issue sadly. This happens because the "Content row" plugin is initialized twice on the same page, and so it has 2 click handlers that toggle it, so first one opens it and second one closes. I can provide a small patch for this specific issue for 3.3.1 (as i've sorted it out while working on something else), but all the other problems with it (like when you try to move it when alias plugin is on same page) will stay unsolved until we refactor. |
@petrklus are you eventually able to help us out there? |
@FinalAngel I am happy to test / evaluate a fix, however, I am not yet at 3.3 and it may take a week or two to upgrade. |
@petrklus helping on testing/evaluating will definitely be a big plus. Also general improvements on the frontend would be very welcome. |
When alias plugin is initialised it also initialises it's children. If the alias plugin is on the same page as the plugin that is being aliased this leads to the event handlers bound twice. So if you try to toggle context menu or nested plugins in structure mode the operation would be ran twice and would technically fail. This commit stops initialisation of the plugin that already has been initialised. Essentially this is a backport of changes from django-cms#5429 Ref: django-cms#5382
When alias plugin is initialised it also initialises it's children. If the alias plugin is on the same page as the plugin that is being aliased this leads to the event handlers bound twice. So if you try to toggle context menu or nested plugins in structure mode the operation would be ran twice and would technically fail. This commit stops initialisation of the plugin that already has been initialised. Essentially this is a backport of changes from django-cms#5429 Ref: django-cms#5382
Fixed by #5486 |
Hi,
I am having issue when using alias to the content on the same page as the content itself.
The overview of the content structure is following:
Tabs container
However, as soon as I create the aliases, I can no longer expand/collapse the content row via the arrow (the expand all option still works), neither can I use the contextual menu (I can use the edit / + buttons).
As soon as the alias is deleted, the contextual buttons start working again for the particular content row.
I can PM login details for a stage server with the issue present on one of the pages. I can also easily reproduce it on my development machine. Sample screenshot:
The offending row is the "Content row" plugin, which cannot be expanded when the alias is present. Works just fine when the alias is removed.
The text was updated successfully, but these errors were encountered: