GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This bug is introduced since 2.1.0rc1 release. (2.1.0beta3 worked)
** Steps to repoduce (using example app) **
** Expected behavior: **
When viewing the published site we expect to see the localized text when switching language (en/fr/de)
** Actual behavior: **
All the translations are viewed on one single page. The other language pages don't show any text at all.
** Cause: **
language = plugins.language
copy_plugins_to(plugins, ph, language)
forces the copied plugin to have the language of the first plugin found, instead of using the src plugin's language.
** Fix: **
cms/utils/copy_plugins.py: *** fixed version! ***
def copy_plugins_to(plugin_list, to_placeholder, to_language = None):
Copies a list of plugins to a placeholder to a language.
ptree = 
plugins_ziplist = 
use_src_language = not to_language
for old_plugin in plugin_list:
if use_src_language: to_language = old_plugin.language
# do the simple copying
new_plugin = old_plugin.copy_plugin(to_placeholder, to_language, ptree)
# this magic is needed for advanced plugins like Text Plugins that can have
# nested plugins and need to update their content based on the new plugins.
for new_plugin, old_plugin in plugins_ziplist:
new_instance = new_plugin.get_plugin_instance()
The bug is fixed in my local git clone. Will try to commit it if possible. Since I don't have experience with git this will be my first 'push', so hopefully it will go well.
For all people using localized pages this will be a show-stopping bug, with no workaround possible except hardcoding in database or django-cms core.
Hopefully my bugfix will be included in rc2 ;)
Keep up doing the great work! Django-cms will be the no1 python cms soon ;)
Hi, if you get this fairly soon, could you please come on irc (#email@example.com) to discuss this (and so I can help you with git).
I committed the changes locally but dont know how to push to github
Can anyone explain me how the contribute workflow works.. ? :)
Thanks Jonas,.. will try to fire up my ages old BitchX ;)
Closed by b531698 (copy_plugin_to copying all plugins to a single language instead of the language of the src plugin)
Okay I was able to reproduce this issue using a unittest.
Thanks a lot to report this very critical bug.
Also I would like to thank you for this absolutely brilliant bug report!
Too bad you didn't get your git to work out, so I applied the patch manually.
For the future:
This issue was fixed in b531698