New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete model instances from admin list view that opens from the toolbar #6495

Open
creimers opened this Issue Aug 29, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@creimers

creimers commented Aug 29, 2018

Summary

I can't delete model instances from the list view that opens from the toolbar. In the "normal" admin list view it does work. From the toolbar opened detailview of the model instance it also works.

Expected behaviour

I'm expecting to be able to delete model instances from the toolbar list view.

Actual behaviour

When confirming the deletion, the modal goes blank. The following error appears in the Javascript console:

Uncaught TypeError: e.match is not a function
    at HTMLAnchorElement.<anonymous> (bundle.toolbar.min.js:1)
    at HTMLAnchorElement.dispatch (bundle.toolbar.min.js:1)
    at HTMLAnchorElement.g.handle (bundle.toolbar.min.js:1)

Environment

  • Python version: 3.6
  • Django version: 1.11
  • django CMS version: 3.5.2

This is happending both in the Firefox and Chrome (latest at time of writing).

@vxsx

This comment has been minimized.

Member

vxsx commented Aug 30, 2018

Could you provide an example project to reproduce?

@vxsx vxsx self-assigned this Aug 30, 2018

@creimers

This comment has been minimized.

@vxsx

This comment has been minimized.

Member

vxsx commented Aug 31, 2018

Thanks!

@vxsx

This comment has been minimized.

Member

vxsx commented Aug 31, 2018

So this happens due to the way browsers attach named inputs to forms. In your case form.action returns an input[name=action] instead of it's action property. I'll add a workaround

@vxsx

This comment has been minimized.

Member

vxsx commented Aug 31, 2018

#6501 fixes the problem for me

@vxsx vxsx added this to the 3.5.3 milestone Aug 31, 2018

@creimers

This comment has been minimized.

creimers commented Aug 31, 2018

I can confirm that it also fixes the problem for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment