New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep older cms.utils.compat version flags for third-party plugins #6578

Open
stefanw opened this Issue Dec 13, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@stefanw
Copy link
Contributor

stefanw commented Dec 13, 2018

Summary

Django CMS 3.6rc1 has removed older DJANGO_* version flags from the cms.utils.compat module.
Third-party extensions still rely on them which means an upgrade of 3.6.x also requires an upgrade of all plugins that rely on that version info via cms.utils.compat.

cms.utils.compat doesn't seem to be a documented API, but it would be an easy thing to keep this version info. Users of third-party plugins, that otherwise work fine, would appreciate it!

Otherwise the upgrade to Django CMS 3.6 will be slower, due to third-party extensions needing to upgrade either via breaking compatibility or each coming up with their own version info.

Expected behaviour

from cms.utils.compat import DJANGO_1_10

This should still work, even though Django 1.10 is no longer supported.

Actual behaviour

ImportError: cannot import name 'DJANGO_1_10'

Environment

  • Python version: 3.6
  • Django version: 1.11
  • django CMS version: 3.6rc1

@stefanw stefanw changed the title Keep cms.compat for third-party plugins checking version info Keep cms.utils.compat version flags for third-party plugins Dec 13, 2018

@stefanw stefanw changed the title Keep cms.utils.compat version flags for third-party plugins Keep older cms.utils.compat version flags for third-party plugins Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment