Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model with placeholder field object permission not honored #6665

Open
darbula opened this issue Apr 4, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@darbula
Copy link
Contributor

commented Apr 4, 2019

Summary

There is an app with model using placeholder field and auth backend checking for object level permission for that model instances but its has_perm method is not receiving instance obj so field is not editable in frontend.

If this line here (same in develop branch) is changed to:

                perm = user.has_perm(change_perm) or user.has_perm(change_perm, obj)

then everything works.

Few years ago there was a PR enabling object level permission check for placeholder but now it seems only documentation part is left.

This issue can be avoided using has_placeholder_change_permission method on custom model, but then at least documentation should be updated to reflect this.

Expected behaviour

The documentation states "permission on related Model or instance" is honored.

Actual behaviour

User permission on instance of the model with placeholder field is not honored.

Environment

  • Python version: 2.7
  • Django version: 1.8.9
  • django CMS version: 3.4.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.