Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your URL pattern uses include with a route ending with a '$'. #6737

Open
Panamus opened this issue Sep 26, 2019 · 1 comment

Comments

@Panamus
Copy link

commented Sep 26, 2019

Summary

URL patterns are having dollar characters appended when they don't exist. This is my current urls.py for this apphook.

app_name = 'membership'
urlpatterns = [
    path('', views.PreSubscribeView.as_view(), name='join'),
    path('subscribe/', views.SubscribeView.as_view(), name='subscribe'),
    path('unsubscribe/', views.UnsubscribeView.as_view(), name='unsubscribe'),
]

I have just upgrade from djangocms 3.5 and django 2.1

Expected behaviour

No warnings to show when running django management commands.

Actual behaviour

WARNINGS:
?: (urls.W001) Your URL pattern '^membership/$' [name='join'] uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs.
?: (urls.W001) Your URL pattern '^membership/subscribe/$' [name='subscribe'] uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs.
?: (urls.W001) Your URL pattern '^membership/unsubscribe/$' [name='unsubscribe'] uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs.

Environment

  • Python version: 3.7.4
  • Django version: 2.2.5
  • Django CMS version: 3.7.0
@rsalmaso

This comment has been minimized.

Copy link

commented Sep 26, 2019

see #6738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.