Skip to content

it should not be possible to access trees with the home slug #885

Closed
ojii opened this Issue Jun 23, 2011 · 0 comments

1 participant

@ojii
ojii commented Jun 23, 2011

If we have a homepage with the slug 'home', it should not be possible to access it and it's children with the URL '/home', but rather only with '/'.

@ojii ojii pushed a commit to ojii/django-cms that referenced this issue Jun 23, 2011
Jonas Obrist Added test for #885 234f773
@ojii ojii pushed a commit to ojii/django-cms that referenced this issue Jul 13, 2011
Jonas Obrist fixed #885, but broke tons of other tests.... 54b2815
@ojii ojii pushed a commit that closed this issue Aug 2, 2011
Jonas Obrist Okay this is a big one:
I wanted to fix #885, which I did.
However it appeared that Page.get_absolute_url was a complete mess.
So I ended up fixing that, by moving page-path (url) logic to post-save (Title/Page) signals and compute them there, and store them in Title.path.
This means Page.get_absolute_url() should be A LOT faster now (=faster menus?), however someone better check that first.
It also means that page/title writes (create,update,move,blah) will be SLOWER, but in my opinion, optimizing reads over writes is preferable.

As a little side effect this commit also potentially fixes #493  due to also fixing #770.

And a further side effect, it will HIDE but NOT FIX #760. Potentially making that bug even more obscure (however it might still show up in the signals).

As you can see, I've changed a lot of tests (because they looked broken in my opinion), so this patch should get extra care.
ba38d2e
@ojii ojii closed this in ba38d2e Aug 2, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.